Make conj_if_needed work with Kokkos::complex #173
#179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mzuzek
changed the title
conj_if_needed work with Kokkos::complex #173conj_if_needed work with Kokkos::complex #173
mhoemmen
requested changes
Apr 21, 2022
...lementations/include/experimental/__p1673_bits/kokkos-kernels/blas2_matrix_rank_2_update.hpp
Outdated
Show resolved
Hide resolved
mzuzek
force-pushed
the
173_refactor_conj-if-needed
branch
from
1a6ca06 to
9448ebc
Compare
mzuzek
changed the title
conj_if_needed work with Kokkos::complex #173conj_if_needed work with Kokkos::complex #173
mzuzek
force-pushed
the
173_refactor_conj-if-needed
branch
from
9448ebc to
b594c2b
Compare
mhoemmen
approved these changes
May 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #173 by adding
Kokkos::complex<T>support tostd::experimental::linalg::impl::conj_if_needed()and removing replicated definitions.